Merged
Conversation
PiotrSikora
requested review from
JimmyCYJ,
bianpengyuan,
duderino,
kyessenov,
lambdai,
linsun,
lizan,
rshriram,
utka,
venilnoronha and
yxue
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/M
PiotrSikora
commented
Aug 7, 2019
|
|
||
| # Link (statically) against libstdc++. | ||
| build --action_env=BAZEL_LINKLIBS=-l%:libstdc++.a | ||
| build --action_env=BAZEL_LINKOPTS=-lm:-static-libgcc |
Contributor
Author
There was a problem hiding this comment.
I synchronized the other options with upstream while at it, but those lines are the real fix.
|
/lgtm |
yxue
approved these changes
Aug 7, 2019
duderino
approved these changes
Aug 7, 2019
PiotrSikora
force-pushed
the
envoy-static
branch
from
5a9e182 to
1167e89
Compare
Broken in istio#2312. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
envoy-static
branch
from
1167e89 to
86d90b2
Compare
Contributor
Author
|
Rebased on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken in #2312.
Signed-off-by: Piotr Sikora piotrsikora@google.com